Add TODO

linkedin · Feb 1, 2025 · f63507a · f63507a
1 parent bf51002
commit f63507a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/test/chunked_loss/test_dpo_loss.py b/test/chunked_loss/test_dpo_loss.py
@@ -233,7 +233,7 @@ def test_correctness(
     for i in range(len(aggregated_aux_outputs1)):
         if i > 4 and dtype == torch.bfloat16:
             # numerical instability in bf16 for chosen_rewards and rejected_rewards
-            # temporary fix
+            # temporary fix. TODO: investigate how to reduce numercial instabiltiy issue
             assert_verbose_allclose(
                 aggregated_aux_outputs1[i],
                 aggregated_aux_outputs2[i],