moving DLO strategy output table to a StrategyDAO for better testing #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
problem:
CREATE TABLE and INSERT INTO for DLO strategy output is currently not tested. this requires more reliance on docker testing. docker testing is manual so prone to forgetting/incorrectly testing. and delete files cannot be easily tested in docker, ref: #287 (comment)
solution:
the
IntegrationTest
infra to create data, test tables, execute DLO strategy, and verify output, already exists, but is in a different module/diff paradigm. already there exists an interface for StrategyDAO, so it is sensible to have both tblprop output and DLO strategy output table under the same interface. this enables shared unittests AND enables testing the DLO strategy output tablenote: in future PR, I will add delete files to the test table so that we aren't testing against the default value of
0
ref: #287 (review)Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
docker results (the reuqirement to do this will be phased out)
docker compose -f infra/recipes/docker-compose/oh-hadoop-spark/docker-compose.yml --profile with_jobs_scheduler run openhouse-jobs-scheduler - --type DATA_LAYOUT_STRATEGY_GENERATION --cluster local --tablesURL http://openhouse-tables:8080 --jobsURL http://openhouse-jobs:8080 --tableMinAgeThresholdHours 0
Additional Information