Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref #54: Drop ctap-types fork & move to cosey crate (fork) #84

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

AlfioEmanueleFresta
Copy link
Member

@AlfioEmanueleFresta AlfioEmanueleFresta commented Feb 23, 2025

Motivation

Makes progress on upstreaming dependency changes, so we can publish our crate.

Previous upstreaming request was declined, as COSE types were moved out of ctap-types, and into the standalone cosey crate (trussed-dev/ctap-types#15).

This PR adopts cosey for COSE types, and drops our ctap-types fork in favour of the published crate.

See #54.

Changes

  • Remove ctap-type fork in favour of:
    • Fork of trussed-dev/cosey for ctap-type::cose (this is no longer part of ctap-types). This fork includes the Deserialize trait for PublicKey, needed in our library.
    • Crate of trussed-dev/ctap-types for existing non-COSE uses (eg. CredentialProtectionPolicy)
  • Update ctap-types to the latest version
  • Update serde-indexed to 0.1.1 as required by updated ctap-types (Cargo.toml)
  • Remove #[serde(default)] annotation, as this is currently not supported and fails altogether with serde-indexed 0.1.1: Support for serde(default) trussed-dev/serde-indexed#10

Follow-up

Drop the fork once change is upstreamed: trussed-dev/cosey#12

@AlfioEmanueleFresta AlfioEmanueleFresta changed the title Ref #54: Move to cosey crate (fork) Ref #54: Drop ctap-types fork & move to cosey crate (fork) Feb 23, 2025
Copy link
Collaborator

@msirringhaus msirringhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlfioEmanueleFresta AlfioEmanueleFresta merged commit 5451cbd into master Feb 24, 2025
4 checks passed
@AlfioEmanueleFresta AlfioEmanueleFresta deleted the cosey branch February 24, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants