Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock wallpaper setting is invalid #390

Closed
wants to merge 1 commit into from

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Dec 30, 2024

when the blur interface is invalid, fallback to normal background

pms: BUG-294645
pms: BUG-285991

when the blur interface is invalid, fallback to normal background

pms: BUG-294645
pms: BUG-285991
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. FullscreenBackground构造函数中新增了m_useBlurBackground成员变量,但未在头文件中声明,可能会导致编译错误。
  2. updateBackground函数中,将m_useBlurBackground设置为true,但这个操作应该根据具体逻辑来决定,而不是无条件地设置为true
  3. updateBlurBackground函数中,当获取模糊背景图片失败时,将m_useBlurBackground设置为false,并调用update()函数。这可能会导致界面刷新,但未检查update()函数是否在获取图片失败时合理调用。
  4. paintEvent函数中,增加了对m_useBlurBackground的判断,但未说明为什么需要这个判断。如果这个判断是必要的,应该添加相应的注释说明。
  5. updateBlurBackground函数中,当获取模糊背景图片失败时,打印了一个警告信息,并添加了then use normal background,这有助于调试,但应该考虑是否有必要在生产环境中保留这些调试信息。
  6. paintEvent函数中,当m_fadeOutAni存在且m_useBlurBackgroundtrue时,才执行相应的绘制逻辑。这可能是为了确保只有在模糊背景可用时才进行绘制,但应该确认这是否是预期的行为。

总体来说,代码的改动看起来是为了增加模糊背景的支持,但需要确保这些改动不会引入新的问题,并且应该添加适当的注释和文档来解释这些改动的原因和影响。

@mhduiy mhduiy closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants