feat: view vs non view properties

liquity · Oct 15, 2024 · 3d192fa · 3d192fa
1 parent c4da233
commit 3d192fa
Showing 1 changed file with 26 additions and 0 deletions.
diff --git a/test/recon/properties/GovernanceProperties.sol b/test/recon/properties/GovernanceProperties.sol
@@ -3,6 +3,7 @@ pragma solidity ^0.8.0;
 
 import {BeforeAfter} from "../BeforeAfter.sol";
 import {Governance} from "src/Governance.sol";
+import {IGovernance} from "src/interfaces/IGovernance.sol";
 
 abstract contract GovernanceProperties is BeforeAfter {
 
@@ -45,4 +46,29 @@ abstract contract GovernanceProperties is BeforeAfter {
         }
     }
 
+    // View vs non view must have same results
+    function property_viewTotalVotesAndStateEquivalency() public {
+        for(uint8 i; i < deployedInitiatives.length; i++) {
+            (IGovernance.InitiativeVoteSnapshot memory initiativeSnapshot_view, , bool shouldUpdate) = governance.getInitiativeSnapshotAndState(deployedInitiatives[i]);
+            (, IGovernance.InitiativeVoteSnapshot memory initiativeVoteSnapshot) = governance.snapshotVotesForInitiative(deployedInitiatives[i]);
+
+            eq(initiativeSnapshot_view.votes, initiativeVoteSnapshot.votes, "votes");
+            eq(initiativeSnapshot_view.forEpoch, initiativeVoteSnapshot.forEpoch, "forEpoch");
+            eq(initiativeSnapshot_view.lastCountedEpoch, initiativeVoteSnapshot.lastCountedEpoch, "lastCountedEpoch");
+            eq(initiativeSnapshot_view.vetos, initiativeVoteSnapshot.vetos, "vetos");
+        }
+    }
+
+    function property_viewCalculateVotingThreshold() public {
+        (, , bool shouldUpdate) = governance.getTotalVotesAndState();
+
+        if(!shouldUpdate) {
+            // If it's already synched it must match
+            uint256 latestKnownThreshold = governance.getLatestVotingThreshold();
+            uint256 calculated = governance.calculateVotingThreshold();
+            eq(latestKnownThreshold, calculated, "match");
+        }
+    }
+
+
 }