Skip to content

Commit

Permalink
Merge pull request #120 from liquity/fix-comments
Browse files Browse the repository at this point in the history
chore: fix incorrect or outdated comments
  • Loading branch information
danielattilasimon authored Dec 27, 2024
2 parents aa5a770 + fb62975 commit b5ade69
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/Governance.sol
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,10 @@ contract Governance is MultiDelegateCall, UserProxyFactory, ReentrancyGuard, Own
}

// == Unregister Condition == //
// e.g. if `UNREGISTRATION_AFTER_EPOCHS` is 4, the 4th epoch flip that would result in SKIP, will result in the initiative being `UNREGISTERABLE`
// e.g. if `UNREGISTRATION_AFTER_EPOCHS` is 4, the initiative will become unregisterable after spending 4 epochs
// while being in one of the following conditions:
// - in `SKIP` state (not having received enough votes to cross the voting threshold)
// - in `CLAIMABLE` state (having received enough votes to cross the voting threshold) but never being claimed
if (
(_initiativeState.lastEpochClaim + UNREGISTRATION_AFTER_EPOCHS < currentEpoch - 1)
|| _votesForInitiativeSnapshot.vetos > _votesForInitiativeSnapshot.votes
Expand Down Expand Up @@ -837,7 +840,7 @@ contract Governance is MultiDelegateCall, UserProxyFactory, ReentrancyGuard, Own

globalState = state;

/// weeks * 2^16 > u32 so the contract will stop working before this is an issue
/// Epoch will never reach 2^256 - 1
registeredInitiatives[_initiative] = UNREGISTERED_INITIATIVE;

// Replaces try / catch | Enforces sufficient gas is passed
Expand Down

0 comments on commit b5ade69

Please sign in to comment.