Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: epoch start was effectively zero in Sepolia deployment #105

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: epoch start was effectively zero in Sepolia deployment #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2193822
fix: epoch start was effectively zero in Sepolia deployment
bingen Dec 18, 2024
45267f5
fix: Remove unused constants from deployment script
bingen Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions script/DeploySepolia.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ contract DeploySepoliaScript is Script, Deployers, MockStakingV1Deployer {
uint32 private constant EPOCH_VOTING_CUTOFF = 518400;

// UniV4Donations Constants
uint256 private immutable VESTING_EPOCH_START = block.timestamp;
uint256 private constant VESTING_EPOCH_DURATION = 7 days;
uint24 private constant FEE = 400;
int24 constant MAX_TICK_SPACING = 32767;

Expand Down Expand Up @@ -90,7 +88,7 @@ contract DeploySepoliaScript is Script, Deployers, MockStakingV1Deployer {
votingThresholdFactor: VOTING_THRESHOLD_FACTOR,
minClaim: MIN_CLAIM,
minAccrual: MIN_ACCRUAL,
epochStart: uint32(block.timestamp - VESTING_EPOCH_START),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes VESTING_EPOCH_START unused. Also, VESTING_EPOCH_DURATION was never used in the first place.

epochStart: block.timestamp - EPOCH_DURATION,
/// @audit Ensures that `initialInitiatives` can be voted on
epochDuration: EPOCH_DURATION,
epochVotingCutoff: EPOCH_VOTING_CUTOFF
Expand Down
Loading