fix: wrong calculation of the bribes given to each user #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingen
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Looks good!
Not strictly related to this PR, but why are all the tests in BribeInitiativeAllocate.t.sol commented out? @RickGriff is it because they still need to be adapted to the new y-intercept refactor? It seems that the test in this PR would fit in that other file better.
|
Yeah, last I heard @RickGriff was going to fix those tests. I would have put the new tests there, but didn't want to conflict with @RickGriff's work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106.