Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNSAFE | TO REDO packing and tests #31

Closed
wants to merge 11 commits into from
Closed

UNSAFE | TO REDO packing and tests #31

wants to merge 11 commits into from

Conversation

GalloDaSballo
Copy link
Collaborator

@GalloDaSballo GalloDaSballo commented Oct 15, 2024 •
edited by nican0r
Loading

  • Change u240 to u120
  • Fix tests that break

@GalloDaSballo
Copy link
Collaborator Author

This merge will be very delicate, we may need to not do it or heavily test it

I think we should re-apply the size changes to the other branch
As well as the test changes

@GalloDaSballo GalloDaSballo mentioned this pull request Oct 16, 2024
Merged
35 tasks
@GalloDaSballo GalloDaSballo changed the title feat: packing and tests UNSAFE | TO REDO packing and tests Oct 21, 2024
@GalloDaSballo GalloDaSballo changed the base branch from dev-governance-refactor to dev October 21, 2024 12:00
@GalloDaSballo
Copy link
Collaborator Author

The change is fundamentally unsafe to add as the spec is unsafe
I recommend keeping this gas optimization in mind and this should be reapplied once you're confident in the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GalloDaSballo @nican0r