Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace Multicall with our own MultiDelegateCall #96

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

danielattilasimon
Copy link
Contributor

Multicall is GPL'd, so we can't inherit it from MIT-licensed code.

Multicall is GPL'd, so we can't inherit it from MIT-licensed code.
Copy link
Contributor

@bingen bingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but are we planning to use this? What for?
If we don’t have clearly defined use case for this, I’d rather remove it. If we do, maybe we can add a test for it.

@danielattilasimon
Copy link
Contributor Author

Turns out there is a test, though it's pretty nonsensical:

function test_multicall() public {

Honestly, dunno why Multicall was included in the first place, maybe @ColinPlatt knows.

@danielattilasimon danielattilasimon merged commit 8709efa into main Dec 6, 2024
3 checks passed
@danielattilasimon danielattilasimon deleted the multicall branch January 19, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants