fix: BatchUpdated event even if Trove isn't batched

liquity · Sep 6, 2024 · 5f9b14c · 5f9b14c
1 parent 65db4b3
commit 5f9b14c
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/contracts/src/TroveManager.sol b/contracts/src/TroveManager.sol
@@ -304,16 +304,18 @@ contract TroveManager is LiquityBase, ITroveManager, ITroveEvents {
             _collChangeFromOperation: -int256(trove.entireColl)
         });
 
-        emit BatchUpdated({
-            _interestBatchManager: batchAddress,
-            _operation: BatchOperation.exitBatch,
-            _debt: batches[batchAddress].debt,
-            _coll: batches[batchAddress].coll,
-            _annualInterestRate: batch.annualInterestRate,
-            _annualManagementFee: batch.annualManagementFee,
-            _totalDebtShares: batches[batchAddress].totalDebtShares,
-            _debtIncreaseFromUpfrontFee: 0
-        });
+        if (isTroveInBatch) {
+            emit BatchUpdated({
+                _interestBatchManager: batchAddress,
+                _operation: BatchOperation.exitBatch,
+                _debt: batches[batchAddress].debt,
+                _coll: batches[batchAddress].coll,
+                _annualInterestRate: batch.annualInterestRate,
+                _annualManagementFee: batch.annualManagementFee,
+                _totalDebtShares: batches[batchAddress].totalDebtShares,
+                _debtIncreaseFromUpfrontFee: 0
+            });
+        }
     }
 
     // Return the amount of Coll to be drawn from a trove's collateral and sent as gas compensation.