Merge pull request #395 from liquity/dedaub_l7

Make claimAllCollGains revert for 0 gains
liquity · Aug 30, 2024 · 7d9c8e6 · 7d9c8e6
2 parents 73ac893 + 425ade1
commit 7d9c8e6
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/contracts/src/StabilityPool.sol b/contracts/src/StabilityPool.sol
@@ -350,6 +350,7 @@ contract StabilityPool is LiquityBase, IStabilityPool, IStabilityPoolEvents {
         activePool.mintAggInterest();
 
         uint256 collToSend = stashedColl[msg.sender];
+        _requireNonZeroAmount(collToSend);
         stashedColl[msg.sender] = 0;
 
         emit DepositOperation(msg.sender, Operation.claimAllCollGains, 0, 0, 0, 0, 0, collToSend);

diff --git a/contracts/src/test/stabilityPool.t.sol b/contracts/src/test/stabilityPool.t.sol
@@ -736,6 +736,29 @@ contract SPTest is DevTestSetup {
         vm.stopPrank();
     }
 
+     function testClaimAllCollGainsRevertsWhenUserHasNoCollGains() public {
+        // A has stashed & current gains, B has only current
+        _setupStashedAndCurrentCollGains();
+
+        // B
+        uint256 compoundedDeposit_B = stabilityPool.getCompoundedBoldDeposit(B);
+        assertGt(compoundedDeposit_B, 0);
+
+        // B withdraws deposit and tries to withdraw stashed coll gains
+        vm.startPrank(B);
+        stabilityPool.withdrawFromSP(compoundedDeposit_B, true);
+        assertEq(stabilityPool.getCompoundedBoldDeposit(B), 0);
+        vm.expectRevert("StabilityPool: Amount must be non-zero");
+        stabilityPool.claimAllCollGains();
+        vm.stopPrank();
+
+        //As does C, who never had a deposit
+        vm.startPrank(C);
+        vm.expectRevert("StabilityPool: Amount must be non-zero");
+        stabilityPool.claimAllCollGains();
+        vm.stopPrank();
+    }
+
     function testClaimAllCollGainsDoesNotChangeCompoundedDeposit() public {
         // A has stashed & current gains, B has only current
         _setupStashedAndCurrentCollGains();