fix: setBatchManagerAnnualInterestRate() breaks SortedTroves orde…

…ring Fixes #359.
liquity · Aug 24, 2024 · aa571dd · aa571dd
1 parent 2f7a2ef
commit aa571dd
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/contracts/src/BorrowerOperations.sol b/contracts/src/BorrowerOperations.sol
@@ -941,16 +941,14 @@ contract BorrowerOperations is LiquityBase, AddRemoveManagers, IBorrowerOperatio
 
         activePoolCached.mintAggInterestAndAccountForTroveChange(batchChange, msg.sender);
 
-        // TODO emit BatchUpdated(msg.sender, batch.entireCollWithoutRedistribution, newDebt, Operation.adjustBatchInterestRate);
-
-        troveManagerCached.onSetBatchManagerAnnualInterestRate(
-            msg.sender, batch.entireCollWithoutRedistribution, newDebt, _newAnnualInterestRate
-        );
-
         // Check batch is not empty, and then reinsert in sorted list
         if (!sortedTroves.isEmptyBatch(BatchId.wrap(msg.sender))) {
             sortedTroves.reInsertBatch(BatchId.wrap(msg.sender), _newAnnualInterestRate, _upperHint, _lowerHint);
         }
+
+        troveManagerCached.onSetBatchManagerAnnualInterestRate(
+            msg.sender, batch.entireCollWithoutRedistribution, newDebt, _newAnnualInterestRate
+        );
     }
 
     function setInterestBatchManager(