App: custom chains support #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add multicall address on Liquity v2 Testnet to sample .env file.
|
This is really neat! Already tested it with Liquity v2 Testnet, and it's working — apart from incompatibilities with the latest contracts. Can we make it so the deployment at https://liquity2.vercel.app supports the testnet outta the box? I think that would make the most sense, as we will never want to deploy a version that lets you interact on mainnet anyway. |
deployment-artifacts-to-app-env.ts changes: - Add the --append option to deployment-artifacts-to-app-env.ts. - It now only validates the options it needs from the context file. Testnet deployment workflow changes: - Pass the chain-related env vars to the app from the deployment workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow arbitrary chains to be set, both in the env vars and/or in the config at runtime (no UI for this yet).