Make _openTrove and _adjustTrove revert when new oracle failure detected #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickGriff
changed the title
bingen
approved these changes
Aug 24, 2024
contracts/src/BorrowerOperations.sol
Outdated
| @@ -1499,6 +1506,12 @@ contract BorrowerOperations is LiquityBase, AddRemoveManagers, IBorrowerOperatio | |||
| } | |||
| } | |||
|
|
|||
| function _requireOraclesLive(bool _newOracleFailureDetected) internal view { | |||
| if (priceFeedDisabled) return lastGoodPrice; | ||
| // fetchPrice returns: | ||
| // - The price | ||
| // - A bool indicating whether a new oracle failure was detected in the call |
There was a problem hiding this comment.
So, if the failure is not new (i.e., the oracle and the branch were already down), this would return false, right?
(or at least that seems to happen in the first line of this function)
Why?
There was a problem hiding this comment.
Right. The intent is to only detect new failures in this call, so that openTrove and adjustTrove revert if they are called in the transaction where the oracle first fails.
If the oracle failed in a previous fetchPrice call, the branch will already be shut down and using the lastGoodPrice
There was a problem hiding this comment.
Ah, yes, of course. Thanks for clarifying!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #336.
_openTroveand_adjustTrovecheck whether an oracle failed, and revert if so.