Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts deploy script: fix debug mode output #374

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Contracts deploy script: fix debug mode output #374

merged 1 commit into from
Sep 2, 2024

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Aug 27, 2024

No description provided.

@bpierre bpierre mentioned this pull request Aug 27, 2024
Merged
danielattilasimon
danielattilasimon approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@danielattilasimon danielattilasimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Does this mean we can see forge output in real time in --debug mode?

@bpierre
Copy link
Contributor Author

bpierre commented Sep 2, 2024

Nice! Does this mean we can see forge output in real time in --debug mode?

Yes I think it’s streaming to the output now, at least it feels like it :)

@bpierre bpierre merged commit 340463e into main Sep 2, 2024
6 of 7 checks passed
@bpierre bpierre deleted the contracts-deploy-script-verbose-fix branch September 2, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielattilasimon danielattilasimon danielattilasimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpierre @danielattilasimon