Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE to app #681

Merged
merged 14 commits into from
Jan 10, 2025
Merged

Add LICENSE to app #681

merged 14 commits into from
Jan 10, 2025

Conversation

ColinPlatt
Copy link
Collaborator

No description provided.

@@ -20,7 +20,7 @@
},
"repository": "github:liquity/bold",
"author": "Liquity AG",
"license": "GPL-3.0",
"license": "BSL-1.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BSL is Boost Software License, it should be BUSL-1.1:
https://spdx.org/licenses/

package.json Outdated
@@ -2,7 +2,7 @@
"name": "liquity2",
"private": true,
"author": "Liquity AG",
"license": "GPL-3.0",
"license": "BSL-1.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@ColinPlatt ColinPlatt marked this pull request as ready for review January 9, 2025 08:42
Copy link
Collaborator

@danielattilasimon danielattilasimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Copy link
Collaborator

@cvalkan cvalkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should explicitly license the subgraph under MIT as we do with the frontend code.
Apart from that, the PR looks good to me.

Copy link
Collaborator

@bingen bingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ColinPlatt ColinPlatt merged commit 40e9aae into main Jan 10, 2025
6 of 7 checks passed
@ColinPlatt ColinPlatt deleted the FE_license_per_pkg branch January 10, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants