Finalize deployment script #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
danielattilasimon
commented
Jan 16, 2025
•
danielattilasimon
commented
- Add another CurveV2GaugeRewards initiative, incentivizing a BOLD-LUSD pool
- Add DeFi Collective's "grants" address (grants.deficollective.eth) as initiative
- Finalize Curve pool parameters (use "Cryto Collateralized Stablecoin" preset)
- Add the "Funds" Safe as distributor of LUSD rewards to both Curve gauges
- Make EPOCH_START configurable
danielattilasimon
force-pushed
the
deployment-script
branch
2 times, most recently
from
9209bb7 to
62e14ad
Compare
| "curveV2GaugeRewardsInitiative": "0x0000000000000000000000000000000000000000", | ||
| "curvePool": "0x5b3f6b88fa29e85778394992d9bcd95ef2fceebe", | ||
| "gauge": "0x0000000000000000000000000000000000000000", | ||
| "LQTYToken": "0x878fc269a85619da792b054e2288cf5f9cc3e2e1" |
There was a problem hiding this comment.
@bpierre heads up, I am renaming some fields in the manifest, because they're ambiguous: we'll have multiple Curve pools, gauges and initiatives on mainnet.
curveV2GaugeRewardsInitiative=>curveUsdcBoldInitiativecurvePool=>curveUsdcBoldPoolgauge=>curveUsdcBoldGauge
Also deleting uniV4DonationsInitiative as we're not going to deploy a Uni v4 initiative.
| asset_types: assetTypes, | ||
| method_ids: methodIds, | ||
| oracles: oracles | ||
| }); |
There was a problem hiding this comment.
Got these parameters by attempting to create a pool on https://curve.fi using the Crypto Collateralized Stablecoins preset, then decoding the hex data. @ColinPlatt does this look good?
danielattilasimon
force-pushed
the
deployment-script
branch
from
62e14ad to
191e6ce
Compare
bingen
approved these changes
Jan 17, 2025
| @@ -54,6 +54,10 @@ import {MockStakingV1} from "V2-gov/test/mocks/MockStakingV1.sol"; | |||
|
|
|||
| import {DeployGovernance} from "./DeployGovernance.s.sol"; | |||
|
|
|||
| function _latestUTCMidnightBetweenWednesdayAndThursday() view returns (uint256) { | |||
There was a problem hiding this comment.
We may add a comment saying that this works because 1/1/1970 was a Thursday 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.