Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sqla_factory): added __set_association_proxy__ attribute #629

Merged
merged 7 commits into from
Jan 24, 2025
Merged

feat(sqla_factory): added __set_association_proxy__ attribute #629

merged 7 commits into from
Jan 24, 2025

Conversation

nisemenov
Copy link
Contributor

Description

  • __set_association_proxy__ attribute has been added in SQLAlchemyFactory class to add AssociationProxy type fields in the result FieldMeta factory dict;
  • appropriate tests have been added;
  • Usage Guide Configuration section has been updated.

Closes

@nisemenov nisemenov requested a review from guacs as a code owner January 15, 2025 12:28
@nisemenov
Copy link
Contributor Author

Hi, @adhtruong!
Thanks for reviewing. I have fixed all issues.

More detailed about #629 (comment): I have rewritten this part more clearly.

@adhtruong
Copy link
Collaborator

Thanks for updating! LGTM

@adhtruong
Copy link
Collaborator

@all-contributors add @nisemenov for code doc

@allcontributors allcontributors bot mentioned this pull request Jan 17, 2025
Open
@allcontributors AllContributors
Copy link
Contributor

@adhtruong

I've put up a pull request to add @nisemenov! 🎉

@adhtruong adhtruong enabled auto-merge (squash) January 24, 2025 17:47
@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/629

@adhtruong adhtruong merged commit 42999fa into litestar-org:main Jan 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhtruong adhtruong adhtruong approved these changes

@guacs guacs Awaiting requested review from guacs guacs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisemenov @adhtruong