Allow range arguments to come as string. #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikalyan
reviewed
Nov 9, 2016
| @@ -1444,6 +1444,8 @@ def _translate_range(self, len_, start, end): | |||
| """ | |||
| Translate range to valid bounds. | |||
| """ | |||
| start = int(start) | |||
There was a problem hiding this comment.
Can you add a test to cover this case?
There was a problem hiding this comment.
Added tester for client.py translation functions.
See comment about general test failure below.
|
Checks for this PR fails due to a general problem in Travis YAML configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MockRedis._translate_range() assumed start and end to be integers but Redis use string for arguments.
Using commands with string range arguments caused errors.
e.g.:
mock_redis.zrange('myzset', '0', '-1') # Always return an empty list before the fix.