Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): crash on reload #35

Merged
merged 3 commits into from
Jun 10, 2024
Merged

fix(iOS): crash on reload #35

merged 3 commits into from
Jun 10, 2024

Conversation

hirbod
Copy link
Contributor

@hirbod hirbod commented Jun 10, 2024

Fix: Prevent Crash in viewControllerDidChangeWidth Method

Summary

This PR fixes a crash in viewControllerDidChangeWidth caused by nil values during React Native reloads.

Changes

Applied optional chaining to handle nil values for bridge and bridge.uiManager.

Copy link

vercel bot commented Jun 10, 2024

@hirbod is attempting to deploy a commit to the Jovanni's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codeclimate bot commented Jun 10, 2024

Code Climate has analyzed commit fccd99d and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@lodev09 lodev09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

ios/TrueSheetView.swift Outdated Show resolved Hide resolved
ios/TrueSheetView.swift Outdated Show resolved Hide resolved
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-true-sheet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 4:49pm

Copy link
Owner

@lodev09 lodev09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goods 👍

@lodev09 lodev09 merged commit 533f2f8 into lodev09:main Jun 10, 2024
7 checks passed
@lodev09
Copy link
Owner

lodev09 commented Jun 10, 2024

🚀 This pull request is included in v0.12.0. See Release 0.12.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants