feat(setting): add upgrade-responder-url setting

Longhorn 10437 Signed-off-by: Derek Su <derek.su@suse.com> (cherry picked from commit 9924f9d)
longhorn · Feb 19, 2025 · 55b7f67 · 55b7f67
1 parent 8b07848
commit 55b7f67
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/controller/setting_controller.go b/controller/setting_controller.go
@@ -53,7 +53,6 @@ const (
 var (
 	upgradeCheckInterval          = time.Hour
 	settingControllerResyncPeriod = time.Hour
-	checkUpgradeURL               = "https://longhorn-upgrade-responder.rancher.io/v1/checkupgrade"
 )
 
 type SettingController struct {
@@ -1157,7 +1156,13 @@ func (sc *SettingController) CheckLatestAndStableLonghornVersions() (string, str
 	if err := json.NewEncoder(&content).Encode(req); err != nil {
 		return "", "", err
 	}
-	r, err := http.Post(checkUpgradeURL, "application/json", &content)
+
+	upgradeResponderURL, err := sc.ds.GetSettingValueExisted(types.SettingNameUpgradeResponderURL)
+	if err != nil {
+		return "", "", err
+	}
+
+	r, err := http.Post(upgradeResponderURL, "application/json", &content)
 	if err != nil {
 		return "", "", err
 	}

diff --git a/types/setting.go b/types/setting.go
@@ -65,6 +65,7 @@ const (
 	SettingNameStorageMinimalAvailablePercentage                        = SettingName("storage-minimal-available-percentage")
 	SettingNameStorageReservedPercentageForDefaultDisk                  = SettingName("storage-reserved-percentage-for-default-disk")
 	SettingNameUpgradeChecker                                           = SettingName("upgrade-checker")
+	SettingNameUpgradeResponderURL                                      = SettingName("upgrade-responder-url")
 	SettingNameAllowCollectingLonghornUsage                             = SettingName("allow-collecting-longhorn-usage-metrics")
 	SettingNameCurrentLonghornVersion                                   = SettingName("current-longhorn-version")
 	SettingNameLatestLonghornVersion                                    = SettingName("latest-longhorn-version")
@@ -163,6 +164,7 @@ var (
 		SettingNameStorageMinimalAvailablePercentage,
 		SettingNameStorageReservedPercentageForDefaultDisk,
 		SettingNameUpgradeChecker,
+		SettingNameUpgradeResponderURL,
 		SettingNameAllowCollectingLonghornUsage,
 		SettingNameCurrentLonghornVersion,
 		SettingNameLatestLonghornVersion,
@@ -283,6 +285,7 @@ var (
 		SettingNameStorageMinimalAvailablePercentage:                        SettingDefinitionStorageMinimalAvailablePercentage,
 		SettingNameStorageReservedPercentageForDefaultDisk:                  SettingDefinitionStorageReservedPercentageForDefaultDisk,
 		SettingNameUpgradeChecker:                                           SettingDefinitionUpgradeChecker,
+		SettingNameUpgradeResponderURL:                                      SettingDefinitionUpgradeResponderURL,
 		SettingNameAllowCollectingLonghornUsage:                             SettingDefinitionAllowCollectingLonghornUsageMetrics,
 		SettingNameCurrentLonghornVersion:                                   SettingDefinitionCurrentLonghornVersion,
 		SettingNameLatestLonghornVersion:                                    SettingDefinitionLatestLonghornVersion,
@@ -585,6 +588,16 @@ var (
 		Default:     "true",
 	}
 
+	SettingDefinitionUpgradeResponderURL = SettingDefinition{
+		DisplayName: "Upgrade Responder URL",
+		Description: "The upgrade responder notifies users the available versions of Longhorn for upgrade",
+		Category:    SettingCategoryGeneral,
+		Type:        SettingTypeString,
+		Required:    true,
+		ReadOnly:    false,
+		Default:     "https://longhorn-upgrade-responder.rancher.io/v1/checkupgrade",
+	}
+
 	SettingDefinitionAllowCollectingLonghornUsageMetrics = SettingDefinition{
 		DisplayName: "Allow Collecting Longhorn Usage Metrics",
 		Description: "Enabling this setting will allow Longhorn to provide additional usage metrics to https://metrics.longhorn.io/.\n" +