fix: changes in configuration to fix some lingering eslint warnings (#…

…867)
losol · Jul 13, 2024 · bf3ef3c · bf3ef3c
1 parent 23cddbc
commit bf3ef3c
Show file tree

Hide file tree

Showing 10 changed files with 52 additions and 25 deletions.
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1 +1 @@
-turbo lint:fix
+npx turbo lint:fix
diff --git a/apps/historia/src/blocks/content.ts b/apps/historia/src/blocks/content.ts
@@ -1,4 +1,4 @@
-import type { Block, Field } from 'payload/types';
+import type { Block } from 'payload/types';
 
 import { richText } from '../fields/richText';
 

diff --git a/apps/web/.eslintrc.js b/apps/web/.eslintrc.js
@@ -3,4 +3,8 @@ module.exports = {
   root: true,
   extends: ['@eventuras/eslint-config/next.js'],
   parser: '@typescript-eslint/parser',
+  globals: {
+    RequestInit: true,
+    ResponseInit: true
+  }
 };
diff --git a/apps/web/src/app/user/events/[id]/EventFlow.tsx b/apps/web/src/app/user/events/[id]/EventFlow.tsx
@@ -21,6 +21,7 @@ import RegistrationView from './eventflow/RegistrationView';
 export interface EventFlowProps {
   eventInfo: EventDto;
   user: UserDto;
+
   availableProducts: ProductDto[];
   siteInfo: SiteInfo;
   registration?: RegistrationDto;

diff --git a/apps/web/src/components/BaseLink.tsx b/apps/web/src/components/BaseLink.tsx
@@ -39,7 +39,7 @@ export const Link = React.forwardRef<HTMLAnchorElement, LinkProps & BoxProps>((p
   let variantClasses = '';
   if (variant?.startsWith('button-')) {
     const buttonVariant = variant.replace('button-', '');
-    if (buttonStyles.hasOwnProperty(buttonVariant)) {
+    if (Object.hasOwnProperty.call(buttonStyles, buttonVariant)) {
       variantClasses = buttonStyles[buttonVariant as keyof typeof buttonStyles];
     }
   }

diff --git a/libs/eslint-config/library.js b/libs/eslint-config/library.js
@@ -5,7 +5,7 @@ const project = resolve(process.cwd(), "tsconfig.json");
 /** @type {import("eslint").Linter.Config} */
 module.exports = {
   extends: ["eslint:recommended", "prettier", "eslint-config-turbo"],
-  plugins: ["only-warn", "import"],
+  plugins: ["only-warn", "import","@typescript-eslint"],
   globals: {
     React: true,
     JSX: true,
@@ -31,7 +31,9 @@ module.exports = {
       files: ["*.js?(x)", "*.ts?(x)"],
     },
   ],
-  rules: {
+  rules:{
     "import/no-duplicates": "error",
-  },
+    "no-unused-vars": "off",
+    "@typescript-eslint/no-unused-vars": ["error"]
+  }
 };
diff --git a/libs/eslint-config/next.js b/libs/eslint-config/next.js
@@ -35,6 +35,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     'turbo/no-undeclared-env-vars': 'off',
     "import/no-duplicates": "error",
+
   },
   settings: {
     'import/resolver': {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -9,10 +9,14 @@
     "@commitlint/config-conventional": "^19.2.2",
     "@eventuras/eslint-config": "*",
     "@eventuras/typescript-config": "*",
+    "@typescript-eslint/eslint-plugin": "^7.16.0",
+    "@typescript-eslint/parser": "^7.16.0",
     "eslint": "^8.57.0",
     "eslint-plugin-import": "^2.29.1",
     "prettier": "^3.3.2",
-    "turbo": "^2.0.6"
+    "turbo": "^2.0.6",
+    "typescript": "^5.5.3",
+    "husky": "^9.0.11"
   },
   "workspaces": [
     "apps/docsite",
@@ -37,7 +41,6 @@
     "prepare": "husky"
   },
   "dependencies": {
-    "husky": "^9.0.11",
     "next": "^14.2.4",
     "nextra": "^2.13.4",
     "nextra-theme-docs": "^2.13.4",

diff --git a/turbo.json b/turbo.json
@@ -1,28 +1,40 @@
 {
   "$schema": "https://turbo.build/schema.json",
-  "globalDependencies": [
-    "**/.env.*local",
-    "**/.env"
+  "globalDependencies": ["**/.env.*local", "**/.env"],
+  "globalEnv": [
+    "CMS_SECRET",
+    "CMS_SERVER_URL",
+    "CMS_ALLOWED_ORIGINS",
+    "CMS_DATABASE_URL",
+    "CMS_MEDIA_S3_ACCESS_KEY_ID",
+    "CMS_MEDIA_S3_SECRET_ACCESS_KEY",
+    "CMS_MEDIA_S3_ENDPOINT",
+    "CMS_MEDIA_S3_REGION",
+    "CMS_MEDIA_S3_BUCKET",
+    "TEST_E2E_EMAIL_ADMIN",
+    "TEST_E2E_EMAIL_USER",
+    "TEST_EMAIL_APP_API_KEY",
+    "TEST_EMAIL_APP_API_URL",
+    "CI",
+    "TEST_BASE_URL"
   ],
   "tasks": {
     "build": {
-      "dependsOn": [
-        "^build"
-      ],
-      "outputs": [
-        ".next/**",
-        "!.next/cache/**"
+      "dependsOn": ["^build"],
+      "outputs": [".next/**", "!.next/cache/**"],
+      "inputs": [
+        "$TURBO_DEFAULT$",
+        ".env.production.local",
+        ".env.local",
+        ".env.production",
+        ".env"
       ]
     },
     "lint": {
-      "dependsOn": [
-        "^lint"
-      ]
+      "dependsOn": ["^lint"]
     },
     "lint:fix": {
-      "dependsOn": [
-        "^lint:fix"
-      ]
+      "dependsOn": ["^lint:fix"]
     },
     "dev": {
       "cache": false,