fix(cache): prevent cache creation to break old data (#118)

louisgrasset · Nov 4, 2023 · 5b1c98d · 5b1c98d
1 parent bdb87ec
commit 5b1c98d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/src/helpers/cache/__tests__/create-cache.spec.ts b/src/helpers/cache/__tests__/create-cache.spec.ts
@@ -2,7 +2,6 @@ import { access } from "fs/promises";
 
 import { INSTANCE_ID } from "../../../constants.js";
 import { createCacheFile } from "../create-cache.js";
-import { getCache } from "../get-cache.js";
 import { writeToCacheFile } from "../write-to-cache-file.js";
 
 jest.mock("fs/promises", () => ({
@@ -19,14 +18,6 @@ jest.mock("../../../constants.js", () => {
   };
 });
 
-jest.mock("../get-cache.js", () => ({
-  getCache: jest.fn().mockResolvedValue({
-    instance: {
-      id: INSTANCE_ID,
-    },
-  }),
-}));
-
 jest.mock("../write-to-cache-file.js", () => ({
   writeToCacheFile: jest.fn(),
 }));
@@ -46,7 +37,6 @@ describe("createCache", () => {
       await createCacheFile();
 
       expect(promiseAccessMock).toHaveBeenCalledTimes(1);
-      expect(getCache).toHaveBeenCalledTimes(1);
       expect(writeToCacheFile).not.toHaveBeenCalled();
     });
   });
@@ -60,7 +50,6 @@ describe("createCache", () => {
       await createCacheFile();
 
       expect(promiseAccessMock).toHaveBeenCalledTimes(1);
-      expect(getCache).not.toHaveBeenCalled();
       expect(writeToCacheFile).toHaveBeenCalledWith({
         version: "0.2",
         instance: { id: INSTANCE_ID },

diff --git a/src/helpers/cache/create-cache.ts b/src/helpers/cache/create-cache.ts
@@ -1,17 +1,12 @@
 import { access, constants } from "fs/promises";
 
 import { CACHE_PATH, INSTANCE_ID } from "../../constants.js";
-import { getCache } from "./get-cache.js";
 import { writeToCacheFile } from "./write-to-cache-file.js";
 
 export const createCacheFile = async () => {
   try {
     // Check if the file exists
     await access(CACHE_PATH, constants.F_OK);
-    const cache = await getCache();
-    if (cache.instance.id !== INSTANCE_ID) {
-      throw new Error(`Cache for instance ${INSTANCE_ID} not found`);
-    }
   } catch {
     writeToCacheFile({
       version: "0.2",