Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for union with generics #261

Merged
merged 1 commit into from
May 10, 2024

Conversation

jasle
Copy link
Contributor

@jasle jasle commented May 9, 2024

Add test for issue #250

@jasle jasle marked this pull request as draft May 9, 2024 21:33
@jasle
Copy link
Contributor Author

jasle commented May 9, 2024

This PR should currently fail the checks with older python versions.

I will remove the draft status when the support for them is dropped.r

@jasle jasle force-pushed the test_union_generics branch from 1fc21cd to aa7e494 Compare May 10, 2024 20:14
@jasle
Copy link
Contributor Author

jasle commented May 10, 2024

Added skipif, ready to merge.

@jasle jasle marked this pull request as ready for review May 10, 2024 20:18
Copy link
Owner

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge this as-is with the skipIf

@lovasoa lovasoa merged commit 5b33c3b into lovasoa:master May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants