Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get in InlineTable #5

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Fix get in InlineTable #5

merged 3 commits into from
Jul 15, 2024

Conversation

ghivert
Copy link
Contributor

@ghivert ghivert commented Jul 9, 2024

Hi!

Inline Tables should behave in the same way as Table for getting keys. 🙂
This creates a bug right now, where to Toml files that are semantically identical, are treated differently.

Have a nice day!

Copy link
Owner

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

Could you add a test and update the changelog please 🙏

@ghivert
Copy link
Contributor Author

ghivert commented Jul 14, 2024

Done!

Copy link
Owner

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

[still_a_section]
still_a_field = 1"
|> tom.parse
|> io.debug
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a debug statement here! I'll remove it

@lpil lpil merged commit 00bb632 into lpil:main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants