-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the filter transformation #121
Open
afausti
wants to merge
21
commits into
master
Choose a base branch
from
tickets/DM-31914
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d41948e
to
d866934
Compare
- This test was implemented as part of the example code to demonstrate Faust tumbling window functionality, it can be moved one level up now.
- Move example code to its own directory
- Also use the example configuration as default for the aggregator configuration
- Avoid collision with AggregatedTopic and AggregatedTopicSchema names - Make code easier to read - Fix tests
- Let the generator read the configuration file and pass the AggregatedTopic object to the Aggregator class
- We are getting the source topics to aggregate from the aggregator configuration which will have a validator for that.
98a6874
to
e340599
Compare
- Add --template-file and --output-dir options to generate-agents command, so we don't need to access the config in the AgentGenerator class
c92e6b4
to
df649c0
Compare
- Refactor initialize() and produce() methods to get source topics from the aggregator configuration - Remove unnecessary configuration parameters - Add --config-file option for ini_example and produce commands
e41f701
to
44c8ce9
Compare
- The filter argument specifies the a list of field names to return - Update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.