Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44091: For len(failed_quanta)>5, display counts and not data_ids #289

Merged
merged 1 commit into from
May 17, 2024

Conversation

eigerx
Copy link
Contributor

@eigerx eigerx commented Apr 26, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.29%. Comparing base (9f21ca1) to head (a906953).

Current head a906953 differs from pull request most recent head e4f1ee5

Please upload reports for the commit e4f1ee5 to get more accurate results.

Files Patch % Lines
python/lsst/ctrl/mpexec/cli/script/report.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   87.35%   87.29%   -0.07%     
==========================================
  Files          50       50              
  Lines        4588     4589       +1     
  Branches      786      787       +1     
==========================================
- Hits         4008     4006       -2     
- Misses        420      421       +1     
- Partials      160      162       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eigerx eigerx force-pushed the tickets/DM-44091 branch 3 times, most recently from e34e052 to 3c3e9d6 Compare April 26, 2024 23:38
Copy link

@erinleighh erinleighh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eigerx eigerx force-pushed the tickets/DM-44091 branch 2 times, most recently from a906953 to bd44f94 Compare May 17, 2024 20:20
@eigerx eigerx force-pushed the tickets/DM-44091 branch from bd44f94 to e4f1ee5 Compare May 17, 2024 20:20
@eigerx eigerx merged commit b95e90d into main May 17, 2024
13 checks passed
@eigerx eigerx deleted the tickets/DM-44091 branch May 17, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants