Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48788: Enable ruff format #1152

Merged
merged 9 commits into from
Feb 7, 2025
Merged

DM-48788: Enable ruff format #1152

merged 9 commits into from
Feb 7, 2025

Conversation

timj
Copy link
Member

@timj timj commented Feb 7, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.47%. Comparing base (84e7e1b) to head (47c30bf).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...hon/lsst/daf/butler/direct_query_driver/_driver.py 50.00% 3 Missing ⚠️
.../daf/butler/registry/queries/_sql_query_context.py 0.00% 2 Missing ⚠️
.../butler/registry/queries/expressions/_predicate.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1152   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files         367      367           
  Lines       49190    49190           
  Branches     5959     5959           
=======================================
  Hits        44014    44014           
  Misses       3757     3757           
  Partials     1419     1419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

timj added 2 commits February 7, 2025 08:36
They are equivalent but linting tools advise against the bare
except.
formatting.yaml now does this.
@timj timj merged commit e060d3e into main Feb 7, 2025
22 checks passed
@timj timj deleted the tickets/DM-48788 branch February 7, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant