Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36303: Replace RFC-878/879 deprecations with removals #891

Merged
merged 18 commits into from
Jan 10, 2024

Add default value to query classes to allow usage to be detected

8ee1e29
Select commit
Loading
Failed to load commit list.
Merged

DM-36303: Replace RFC-878/879 deprecations with removals #891

Add default value to query classes to allow usage to be detected
8ee1e29
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project failed Jan 9, 2024 in 0s

88.34% (-0.03%) compared to d8d7886

View this Pull Request on Codecov

88.34% (-0.03%) compared to d8d7886

Details

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (d8d7886) 88.37% compared to head (8ee1e29) 88.34%.

Files Patch % Lines
python/lsst/daf/butler/registry/sql_registry.py 57.57% 10 Missing and 4 partials ⚠️
...ython/lsst/daf/butler/registry/queries/_results.py 60.00% 2 Missing and 2 partials ⚠️
python/lsst/daf/butler/cli/cmd/commands.py 25.00% 2 Missing and 1 partial ⚠️
python/lsst/daf/butler/direct_query_results.py 80.00% 2 Missing ⚠️
.../butler/registry/datasets/byDimensions/_manager.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   88.37%   88.34%   -0.03%     
==========================================
  Files         301      301              
  Lines       38854    38752     -102     
  Branches     8186     8165      -21     
==========================================
- Hits        34337    34237     -100     
+ Misses       3343     3334       -9     
- Partials     1174     1181       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov