Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41158: (mostly) implement QueryDriver for DirectButler #915

Merged
merged 23 commits into from
Apr 5, 2024

Add test for DirectQueryDriver with PostgreSQL.

8a03dd5
Select commit
Loading
Failed to load commit list.
Merged

DM-41158: (mostly) implement QueryDriver for DirectButler #915

Add test for DirectQueryDriver with PostgreSQL.
8a03dd5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 5, 2024 in 0s

88.95% (-0.03%) compared to c0af174

View this Pull Request on Codecov

88.95% (-0.03%) compared to c0af174

Details

Codecov Report

Attention: Patch coverage is 87.63736% with 180 lines in your changes are missing coverage. Please review.

Project coverage is 88.95%. Comparing base (c0af174) to head (8a03dd5).

Files Patch % Lines
...hon/lsst/daf/butler/direct_query_driver/_driver.py 83.49% 42 Missing and 26 partials ⚠️
.../butler/registry/datasets/byDimensions/_storage.py 47.05% 24 Missing and 12 partials ⚠️
...t/daf/butler/direct_query_driver/_query_builder.py 87.42% 11 Missing and 10 partials ⚠️
...thon/lsst/daf/butler/registry/dimensions/static.py 84.52% 7 Missing and 6 partials ⚠️
...thon/lsst/daf/butler/queries/expression_factory.py 87.17% 9 Missing and 1 partial ⚠️
.../daf/butler/direct_query_driver/_postprocessing.py 88.05% 3 Missing and 5 partials ⚠️
...lsst/daf/butler/direct_query_driver/_query_plan.py 94.44% 5 Missing and 2 partials ⚠️
.../butler/direct_query_driver/_sql_column_visitor.py 96.74% 2 Missing and 2 partials ⚠️
python/lsst/daf/butler/tests/butler_queries.py 97.89% 2 Missing and 2 partials ⚠️
python/lsst/daf/butler/name_shrinker.py 62.50% 3 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   88.97%   88.95%   -0.03%     
==========================================
  Files         329      338       +9     
  Lines       42631    44014    +1383     
  Branches     8743     9071     +328     
==========================================
+ Hits        37933    39151    +1218     
- Misses       3445     3549     +104     
- Partials     1253     1314      +61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov