Use connection provider for quartz as well. #122
Conversation
| * WARNING: This is intedned for the properties to all be set, and then `initialize` called to set everything up, after | ||
| * which the properties should be left unchanged. | ||
| */ | ||
| class BeanConnectionProvider extends org.quartz.utils.ConnectionProvider { |
There was a problem hiding this comment.
If BeanConnectionProvider just initiates a new ConnectionProvider which already extends org.quartz.utils.ConnectionProvider, why does this class need to extend that class too?
There was a problem hiding this comment.
Because it is necessary for it to be used by quartz as the connection provider class.
Technicaly, ConnectionProvider doesn't need to extend that interface, but I figured it might as well.
This instantiates a new ConnectionProvider, but it doesn't expose it to the quartz caller (it can't).
There was a problem hiding this comment.
Technicaly, ConnectionProvider doesn't need to extend that interface, but I figured it might as well.
Can we remove that extension? I think it may confuse future me and other developers why we have a connection provider wrapping a connection provider :)
Make it so that quartz can use our custom Quartz Provider as well as the admin controllers.
This creates a new
com.lucidchart.piezo.BeanConnectionProviderclass that can be used with theconnectionProvider.classconfiguration, so that quartz itself will use the same connection provider as the controllers.