Support resolving config #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
force-pushed
the
support-resolving-config
branch
from
82e1931 to
7d25f30
Compare
Also support disabling comments if desired. At one point there was some problem with calling resolve on the configuration before rendering. But that was several versions of the hocon library ago, and I haven't been able to find a case where the output after calling resolve produces unexpected output. And my archaelogy hasn't been able to discover the exact scenario that caused me to decide not to do the resolution before rendering. Just in case it does cause issues, I have made it configurable, so resolving references can be disabled if needed.
tmccombs
force-pushed
the
support-resolving-config
branch
from
7d25f30 to
c1e5d61
Compare
DavidANeil
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support resolving configuration in output
Also support disabling comments if desired.
At one point there was some problem with calling resolve on the configuration before rendering.
But that was several versions of the hocon library ago, and I haven't been able to find a case where
the output after calling resolve produces unexpected output. And my archaelogy hasn't been able to
discover the exact scenario that caused me to decide not to do the resolution before rendering.
Just in case it does cause issues, I have made it configurable, so resolving references can be
disabled if needed.