Some fixes #28
Merged
Some fixes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because apparantly it causes problems when used. Instead call executable directly from the format.sh script
There are some cases where resolve is problematic, so to be safe leave it off by default. Cases where resolve causes problems: 1. If you use += it can produce invalid config, and if you use more than a handful even cause an OOM 2. If a value a reference is used in one config, and we resolve, then we override the referenced value in a downstream dependency, we get the wrong value. So resolve should only be used in the last stage when you have multiple dependencies.
DavidANeil
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.