refactor: simplify sale method input by using SecureSale type

lucrise-llc · Dec 4, 2024 · b2ba5b4 · b2ba5b4
1 parent d108891
commit b2ba5b4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/azul-api/secure/secure.ts b/src/azul-api/secure/secure.ts
@@ -1,9 +1,9 @@
 import { randomUUID } from 'crypto';
 import { ProcessPaymentTransaction } from '../process-payment/process-payment';
-import { ProcessPaymentSchema, ProcessPaymentSchemaInput } from '../process-payment/schemas';
+import { ProcessPaymentSchema } from '../process-payment/schemas';
 import { Process } from '../processes';
 import AzulRequester from '../request';
-import { BrowserInfo, CardHolderInfo, MethodNotificationStatus, ThreeDSAuth } from './types';
+import { MethodNotificationStatus, SecureSale } from './types';
 import { sleep } from '../../utils';
 
 type SecurePaymentSession = {
@@ -20,15 +20,7 @@ export class Secure {
     this.requester = requester;
   }
 
-  async sale(
-    input: ProcessPaymentSchemaInput & {
-      cardHolderInfo: CardHolderInfo;
-      browserInfo: BrowserInfo;
-      threeDSAuth: ThreeDSAuth;
-    } & {
-      useIframe?: boolean;
-    }
-  ): Promise<
+  async sale(input: SecureSale): Promise<
     | {
         redirect: true;
         id: string;

diff --git a/src/azul-api/secure/types.ts b/src/azul-api/secure/types.ts
@@ -1,3 +1,13 @@
+import type { ProcessPaymentSchemaInput } from '../process-payment/schemas';
+
+export type SecureSale = ProcessPaymentSchemaInput & {
+  cardHolderInfo: CardHolderInfo;
+  browserInfo: BrowserInfo;
+  threeDSAuth: ThreeDSAuth;
+} & {
+  useIframe?: boolean;
+};
+
 export enum ChallengeIndicator {
   /**
    * Sin preferencias (no tiene preferencia si se debe realizar un desafío.