Revert "Delete create_db.py (#1000)"
#1152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandoned-prototype
requested review from
b-meson,
michplunkett,
AetherUnbound and
sea-kelp
| @@ -52,7 +52,7 @@ repos: | |||
| description: Only executable files should have shebangs (e.g. '#!/usr/bin/env python') | |||
| entry: "#!/" | |||
| pass_filenames: true | |||
| exclude: bin|cli|manage.py|app.py|setup.py|docs|test_data.py | |||
| exclude: bin|cli|manage.py|app.py|setup.py|docs|create_db.py|test_data.py | |||
There was a problem hiding this comment.
We can leave create_db off of this list, yeah?
| @@ -19,6 +14,12 @@ | |||
| logger = logging.getLogger("alembic.env") | |||
|
|
|||
|
|
|||
| config.set_main_option( | |||
| "sqlalchemy.url", current_app.config.get("SQLALCHEMY_DATABASE_URI") | |||
There was a problem hiding this comment.
Could you change this to: "sqlalchemy.url", current_app.config.get(KEY_DATABASE_URI)?
| from OpenOversight.app.models.database import db | ||
|
|
||
|
|
||
| app = create_app("development") |
| @@ -0,0 +1,9 @@ | |||
| #!/usr/bin/python | |||
There was a problem hiding this comment.
We don't need the shebang, right?
michplunkett
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#1000 unfortunately broke alembic's functionality to create migrations that include new tables (Using
flask db migrate). The issue is that before alembic has a change to analyze the difference between existing database and schema from database.py thedb.create_all()command automatically creates the tables making it so that they are not registered for the migration.I could not come up with a way to reasonably work around this issue, so I think the best course of action is to revert the removal of the create_db.py file.
Description of Changes
This reverts that breaking commit. It is not a clean revert of #1000, since that PR also included unrelated changes to tests and constants. Those changes were not reverted.
Notes for Deployment
I have verified the changes in my local environment and the tests are passing, but I have not tested that the changes work as expected in a completely fresh environment (which would use the create_db file)
Tests and Linting
developbranch.make create_db_diagramcommand.pytestpasses on my local development environment.pre-commitpasses on my local development environment.