-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notion of sampler #12
base: main
Are you sure you want to change the base?
Conversation
Hi @luisfpereira,
Besides that, it seems that everything is working, |
Thank you for the comments and notebook @gviga.
Yes, the distinction is between continuous vs discrete. So, I'm considering that doing My main goal is to have a compatible API for the
What would be a use case of this feature in the notebook? |
Yes, you are right, I agree that calling vertices[indices] is not expensive and it's the way to go for now. Thank you @luisfpereira |
Now is available sampling the farthest points.
The register is already defined following the new registry structure
Inspired by #9, this PR brings in the notion of sampler.
Notice this commit was initially done in 415cd8d.
Nevertheless, I believe this code is mature enough to merge (maybe after adding a notebook showing how this work?), whereas we still have a lot of work to do with #9.
Still need to address a couple of comments I've left in the code.