New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend PyTorch: Add L1 regularizers #1905

Merged

lululxvi merged 6 commits into lululxvi:master from vl-dud:pytorch-l1-regularizer

Mar 19, 2025

Contributor

vl-dud commented Dec 3, 2024 •

edited

Loading

Continuation of the PR #1884


          Backend PyTorch: Add L1 and L1+L2 regularizers

c260a0b

Owner

lululxvi commented Dec 8, 2024

We are unifying the regularization for tensorflow and paddle, see #1894 . Do you think we can also unify pytorch regularization in a more unified code?

Contributor Author

vl-dud commented Dec 8, 2024

Unfortunately, this can be a bit difficult in pytorch. The implementation options seem unnecessarily complicated to me.

lululxvi reviewed

View reviewed changes

deepxde/model.py Outdated Show resolved Hide resolved


          Remove l1+l2 regularization

be13e32

Contributor Author

vl-dud commented Dec 19, 2024 •

edited

Loading

I didn't notice earlier that you implemented the NysNewtonCG optimizer. Should I add L1 regularization in train_step_nncg?

Owner

lululxvi commented Jan 20, 2025

I didn't notice earlier that you implemented the NysNewtonCG optimizer. Should I add L1 regularization in train_step_nncg?

Not this PR.

Owner

lululxvi commented Jan 20, 2025

Sorry, it has been a while for this PR. Could you remind me what is the purpose of this PR?

Contributor Author

vl-dud commented Jan 20, 2025

Sorry, it has been a while for this PR. Could you remind me what is the purpose of this PR?

This is a pytorch implementation of L1 regularization.

lululxvi reviewed

View reviewed changes

deepxde/model.py Outdated Show resolved Hide resolved


          Move L1 loss to outputs_losses

eacdc41

lululxvi reviewed

View reviewed changes

deepxde/model.py Outdated Show resolved Hide resolved

lululxvi reviewed

View reviewed changes

deepxde/model.py Outdated Show resolved Hide resolved


          Change error message

a31d197

lululxvi reviewed

View reviewed changes

deepxde/model.py Outdated Show resolved Hide resolved


          Fix interaction of L1 regularization with loss weights

cdec9c7

lululxvi reviewed

View reviewed changes

deepxde/model.py Outdated Show resolved Hide resolved


          Refactoring

3d7f459

lululxvi merged commit bd43c6c into lululxvi:master

13 checks passed

lululxvi changed the title ~~Backend PyTorch: Add L1 and L1+L2 regularizers~~ Backend PyTorch: Add L1 regularizers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet