Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(discovery): make the SDK use static discovery files #195

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

beroussel
Copy link
Contributor

GAE runtime will soon enough be decommissionned. To allow API discovery to continue working without breaking change, make the SDK rely on static discovery files hosted on LumApps CDN.

@beroussel beroussel requested review from lumautomation and a team as code owners August 13, 2024 14:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.81%. Comparing base (5628435) to head (0c5b966).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lumapps/api/base_client.py 83.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   85.64%   85.81%   +0.16%     
==========================================
  Files          16       16              
  Lines         843      853      +10     
  Branches      168      171       +3     
==========================================
+ Hits          722      732      +10     
  Misses         78       78              
  Partials       43       43              
Flag Coverage Δ
unittests 85.81% <83.33%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lumapps/api/base_client.py 79.93% <83.33%> (+0.71%) ⬆️

GAE runtime will soon enough be decommissionned. To allow API discovery to continue
working without breaking change, make the SDK rely on static discovery files hosted
on LumApps CDN.
@beroussel beroussel force-pushed the chore/use-static-discovery branch from 9eb327f to 0c5b966 Compare September 2, 2024 14:43
@beroussel beroussel merged commit 801a4ce into master Sep 2, 2024
7 checks passed
@beroussel beroussel deleted the chore/use-static-discovery branch September 2, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants