Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS-13] Dialog 디자인 검수 & 스타일 수정 #177

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

HyejinYang
Copy link
Contributor

@HyejinYang HyejinYang commented Jun 24, 2024

Description

DS-13

  • Dialog 디자인 검수를 받아 스타일 수정을 진행했습니다.
  • 주요 변경점: css로 box-shadow를 지정해주는 방식이 아닌, 클래스를 통해 elevation2를 불러오는 방식을 이용했습니다. (루닛 디자인 시스템의 elevation은 토큰이 아닌 클래스로 사용 가능합니다!)

@HyejinYang HyejinYang added the enhancement New feature or request label Jun 24, 2024
@HyejinYang HyejinYang requested review from deminoth and a team June 24, 2024 08:11
@HyejinYang HyejinYang self-assigned this Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

Design System Storybook: https://62d7d1f2efc8a1e364b5e5e8-wfzwmbjctj.chromatic.com/

@deminoth
Copy link
Member

주요 변경점: css로 box-shadow를 지정해주는 방식이 아닌, 클래스를 통해 elevation2를 불러오는 방식을 이용했습니다.

링크가 안 들어가지네요

@HyejinYang
Copy link
Contributor Author

@deminoth 디자인 검수 중에 수정 사항 몇 개를 추가로 발견해서 고쳤습니다.

  • padding 조절
  • action dialog일 때 backButtonClose 불가

@HyejinYang HyejinYang merged commit 14108dd into main Jun 25, 2024
5 checks passed
@HyejinYang HyejinYang deleted the DS-13-dialog-style branch June 25, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants