Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.2.0 version Minor Release #425

Merged
merged 1 commit into from
Nov 1, 2024
Merged

7.2.0 version Minor Release #425

merged 1 commit into from
Nov 1, 2024

Conversation

LTakhyunKim
Copy link
Collaborator

๐Ÿ“ Description

์•„๋ž˜ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ํฌํ•จํ•œ 7.2.0 ๋ฆด๋ฆฌ์ฆˆ ์šฉ PR ์ž…๋‹ˆ๋‹ค.
CHANGELOG ๋ฐ version bump ๋ฅผ ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • CXR4 ์šฉ Heatmap Viewer ์ถ”๊ฐ€
  • React v18 peer dependency ์—…๋ฐ์ดํŠธ

โœ”๏ธ PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Chore (non-breaking change which does not affect codebase; Build related changes, version modification, etc.)
  • CI related changes
  • Test Case
  • Performance optimization
  • Site/documentation update
  • Other... Please describe:

๐Ÿ’ฃ Is this a breaking change?

  • Yes
  • No

@LTakhyunKim LTakhyunKim requested a review from deminoth as a code owner November 1, 2024 02:59
@LTakhyunKim LTakhyunKim self-assigned this Nov 1, 2024
@LTakhyunKim LTakhyunKim added the minor Increment the minor version when merged label Nov 1, 2024
@LTakhyunKim LTakhyunKim requested a review from a team November 1, 2024 03:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Coverage report

St.โ”
 Category Percentage Covered / Total
๐ŸŸข Statements 93.02% 80/86
๐ŸŸข Branches 94.55% 52/55
๐ŸŸก Functions 77.78% 21/27
๐ŸŸข Lines 92.31% 72/78

Test suite run success

66 tests passing in 9 suites.

Report generated by ๐Ÿงชjest coverage report action from 19c4d87

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

preview: https://insight-viewer--pr-425.f.lunit.io/

deminoth
deminoth approved these changes Nov 1, 2024
View reviewed changes
CHANGELOG.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semver์˜ changelog ์จ์ฃผ๋Š” ๊ธฐ๋Šฅ์„ ์ž˜ ํ™œ์šฉํ•˜๋ ค๋ฉด squash๋‚˜ rebase๋ฅผ ํ•ด์•ผ ํ•  ๊ฒƒ ๊ฐ™๋„ค์š”

Copy link
Collaborator Author

@LTakhyunKim LTakhyunKim Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ปค๋ฐ‹ ๋‹จ์œ„๋กœ ํ‘œ๊ธฐ๋˜๋Š” ๊ฒƒ์ด ์•„๋‹Œ ์ž‘์—… ๋‹จ์œ„๋กœ ํ‘œ๊ธฐํ•ด์„œ changelog ๊ฐ€๋…์„ฑ์„ ๋†’์ด๊ธฐ ์œ„ํ•œ ๋ชฉ์ ์ผ๊นŒ์š”?
์ž˜ ํ™œ์šฉํ•˜๊ธฐ ์œ„ํ•œ ๋ฐฉ๋ฒ•์œผ๋กœ squash, rebase ๋ฅผ ๋ง์”€ํ•ด์ฃผ์‹  ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ด์„œ ์ฝ”๋ฉ˜ํŠธ ๋‚จ๊น๋‹ˆ๋‹ค.
(v8 ๋ฐฐํฌ ํ”„๋กœ์„ธ์Šค๋ฅผ ์žฌ๊ตฌ์ถ• ํ•  ๋•Œ ์ฐธ๊ณ ํ•˜๊ณ ์ž ํ•ฉ๋‹ˆ๋‹ค)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋งž์Šต๋‹ˆ๋‹ค ์˜ˆ์ „์— challenge ๋ฆด๋ฆฌ์Šค ์ž๋™ํ™”๋•Œ๋„ ๋น„์Šทํ•œ ์ด์•ผ๊ธฐ๊ฐ€ ๋‚˜์™”๋˜ ๊ฒƒ ๊ฐ™๋„ค์š”

@LTakhyunKim LTakhyunKim merged commit 0d750be into master Nov 1, 2024
5 checks passed
@LTakhyunKim LTakhyunKim deleted the release/7.2.0 branch November 1, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deminoth deminoth deminoth approved these changes

Assignees

@LTakhyunKim LTakhyunKim

Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LTakhyunKim @deminoth