Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web-core): improve LynxView resize observer cleanup #124

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor(web-core): improve LynxView resize observer cleanup #124

wants to merge 6 commits into from

Conversation

BronzonTech-Cloud
Copy link

  • Extract resize observer cleanup into a separate method
  • Ensure proper disconnection and clearing of resize observer
  • Add type safety to nativeModulesCall callback

@BronzonTech-Cloud
refactor(web-core): improve LynxView resize observer cleanup
00bf8cb 
- Extract resize observer cleanup into a separate method
- Ensure proper disconnection and clearing of resize observer
- Add type safety to nativeModulesCall callback
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d8cc71f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

BronzonTech-Cloud and others added 2 commits March 7, 2025 12:34
@BronzonTech-Cloud
Merge branch 'main' into main
ebb5371
@BronzonTech-Cloud
refactor(web-core): improve type safety for nativeModulesCall callback
2232d50 
- Add explicit type annotation for nativeModulesCall arguments
- Enhance type definition for native modules callback parameters
@BronzonTech-Cloud BronzonTech-Cloud marked this pull request as draft March 7, 2025 12:46
@BronzonTech-Cloud BronzonTech-Cloud marked this pull request as ready for review March 7, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PupilTong PupilTong Awaiting requested review from PupilTong PupilTong is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BronzonTech-Cloud @CLAassistant