Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing-library): add @lynx-js/lynx-dom #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

upupming
Copy link
Collaborator

@upupming upupming commented Mar 5, 2025

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: bcf2d8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@upupming upupming force-pushed the feat/testing-library-lynx-dom branch from 99d217d to 619b54e Compare March 5, 2025 06:37
@upupming upupming requested a review from colinaaa March 10, 2025 02:10
@upupming upupming force-pushed the feat/testing-library-lynx-dom branch 2 times, most recently from c3acc88 to 98a7db8 Compare March 12, 2025 02:27

export type ThreadType = 'background' | 'main';

export class LynxDOM {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename this to LynxToplevel or something. We shouldn't confuse our setup with Web DOM furthermore.

Additionally, I encourage you to add more documentation-comments whenever you declared a new concept.

I wouldn't even concern about you use AI to generate such doc comments as a starting point, so you can understand how AI read through your code.

@upupming upupming force-pushed the feat/testing-library-lynx-dom branch 2 times, most recently from ba6b2a2 to 72255d4 Compare March 12, 2025 11:44
@upupming upupming force-pushed the feat/testing-library-lynx-dom branch from 72255d4 to bcf2d8a Compare March 12, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants