-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testing-library): add @lynx-js/lynx-dom #64
base: main
Are you sure you want to change the base?
Conversation
|
99d217d
to
619b54e
Compare
c3acc88
to
98a7db8
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
|
||
export type ThreadType = 'background' | 'main'; | ||
|
||
export class LynxDOM { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename this to LynxToplevel or something. We shouldn't confuse our setup with Web DOM furthermore.
Additionally, I encourage you to add more documentation-comments whenever you declared a new concept.
I wouldn't even concern about you use AI to generate such doc comments as a starting point, so you can understand how AI read through your code.
ba6b2a2
to
72255d4
Compare
72255d4
to
bcf2d8a
Compare
Summary
Checklist