Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new label to Kubernetes request metric #146

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

cristinaleonr
Copy link
Contributor

@cristinaleonr cristinaleonr commented Jul 20, 2023

This PR adds a new metric to the Kubernetes request metric to differentiate between pod and node requests.


This change is Reviewable

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@cristinaleonr cristinaleonr merged commit bacf420 into main Jul 20, 2023
@cristinaleonr cristinaleonr deleted the sandbox-cristinaleon-metrics-k8s branch July 20, 2023 20:09
@cristinaleonr
Copy link
Contributor Author

Related to #149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants