Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tests from distributions #72

Merged

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Oct 31, 2024

Hi there!

The PyPI distributions of this package currently clobber the environment namespace with a top-level test package. With this PR, I suggest fixing this.

I stumbled upon this when trying to add your (fantastic!) package to the conda-forge packaging ecosystem: conda-forge/staged-recipes#28067.

@m-wrzr m-wrzr changed the base branch from main to v0.1.19-remove-tests-from-dist November 1, 2024 11:03
@m-wrzr
Copy link
Owner

m-wrzr commented Nov 1, 2024

Thanks a lot! Didn't realize it also shipped the test package.. I'll deploy this in with version 0.1.19 👍

@m-wrzr m-wrzr merged commit 6f4c450 into m-wrzr:v0.1.19-remove-tests-from-dist Nov 1, 2024
m-wrzr added a commit that referenced this pull request Nov 1, 2024
* remove tests from distributions (#72)

* version bump 0.1.19

---------

Co-authored-by: Yannik Tausch <dev@ytausch.de>
@ytausch ytausch deleted the pypi-remove-tests branch November 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants