fix: ensure baseFormatter.format is called when event name is not rec…

…ognized; test: add mock for baseFormatter to verify format method calls
madeiramadeirabr · Sep 3, 2024 · 4f85225 · 4f85225
1 parent 69653fd
commit 4f85225
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/src/core/log-standard-event-formatter-decorator.ts b/src/core/log-standard-event-formatter-decorator.ts
@@ -61,10 +61,7 @@ export class LogStandardEventFormatterDecorator implements FormatterInterface {
       !args.global_event_name ||
       !this.isKnownEventName(args.global_event_name)
     ) {
-      return JSON.stringify({
-        ...formattedMessage,
-        context: args?.context || {},
-      });
+      return this.baseFormatter.format(message, level, args);
     }
 
     args.context = args.context || {};
@@ -77,4 +74,4 @@ export class LogStandardEventFormatterDecorator implements FormatterInterface {
       context: args.context,
     });
   }
-}
+}
diff --git a/tests/unit/log-standard-event-formatter-decorator.spec.ts b/tests/unit/log-standard-event-formatter-decorator.spec.ts
@@ -10,6 +10,7 @@ describe('Formatter', () => {
   beforeEach(() => {
     mockFormatter = {
       serviceName: 'service',
+      format: jest.fn()
     } as unknown as jest.Mocked<FormatterInterface>;
 
     logStandardFormatterDecorator = new LogStandardEventFormatterDecorator(mockFormatter);
@@ -20,6 +21,17 @@ describe('Formatter', () => {
   });
 
   it('Should format correctly with a generic event name', () => {
+    mockFormatter.format.mockReturnValue(
+      JSON.stringify({
+        message: 'mensagem',
+        level: LogLevel.info,
+        global_event_timestamp: '2021-01-01T03:00:00.000Z',
+        service_name: 'service',
+        global_event_name: 'teste',
+        context: {},
+      })
+    );
+
     const response = logStandardFormatterDecorator.format('mensagem', LogLevel.info, {
       global_event_name: 'teste',
     });
@@ -30,10 +42,14 @@ describe('Formatter', () => {
       global_event_timestamp: '2021-01-01T03:00:00.000Z',
       service_name: 'service',
       global_event_name: 'teste',
-      context: {}
+      context: {},
     });
 
     expect(response).toBe(expected);
+
+    expect(mockFormatter.format).toHaveBeenCalledWith('mensagem', LogLevel.info, {
+      global_event_name: 'teste',
+    });
   });
 
   it('Should format correctly when PROCESS_STARTUP_FAILED is sent with all required fields and correct log level', () => {