Add deterministic ability ID generation to PermanentImpl.addAbility #13465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11560
Does NOT fix #10372 - Most likely due to the Effect ID changing each call (CopyEffect.java:copyToPermanent)
Potentially an alternate solution to #10802
I'm open to suggestions about the methodology for generating the new UUID. I wanted to adhere to the following requirements:
I considered using
RandomUtil
, but converting multiple UUIDs into a singlelong
forsetSeed
would reduce the seed space by a big factor and increase the probability of UUID collisions. I don't know if that's significant or not, but i didn't want to chance it with this change that has such widespread implications for the engine.