Add support for Petoneer Fresco EzGo pet fountain (WF005) #2880
Conversation
- should be translation_key, lights don't support classes Noticed PR #2880 has copied it from somewhere, and found 3 occurrences.
custom_components/tuya_local/devices/petoneer_fresco_ezgo_petfountain.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/petoneer_fresco_ezgo_petfountain.yaml
Outdated
Show resolved
Hide resolved
| - dps_val: smart | ||
| value: geyser | ||
| - entity: sensor | ||
| name: Filter cleaning in |
There was a problem hiding this comment.
Generally I would use a name of "Filter remaining". It will make later translations easier if it is consistent with other configs.
There was a problem hiding this comment.
I copied this from the Fresco Mini config, that might need updating too, as I now see other places are more consistent.
custom_components/tuya_local/devices/petoneer_fresco_ezgo_petfountain.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/petoneer_fresco_ezgo_petfountain.yaml
Outdated
Show resolved
Hide resolved
| - dps_val: 1 | ||
| value: true | ||
| - entity: binary_sensor | ||
| name: Error |
There was a problem hiding this comment.
Remove the name to let the class translations show through.
Generally also, I would include a "fault_code" attribute, with the raw value of dp 23.
I'd also suggest separating routine things out from the maintenance issues to their own binary_sensor (dps_val: 1 especially, there is a tank_empty translation key defined for such binary_sensors).
There was a problem hiding this comment.
It's kind of weird, this mostly overlaps water_level, which is why I kept it like that.
custom_components/tuya_local/devices/petoneer_fresco_ezgo_petfountain.yaml
Show resolved
Hide resolved
Fixes make-all#2878, except for scheduling, which will require some custom code.
- add model_id from PR Issue #2878
Fixes #2878, except for scheduling, which will require some custom code.