Drop support for Python 3.9, add support for numpy 2.x #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimanfoo
changed the title
|
Test failures need a fix upstream in scikit-allel. |
alimanfoo
changed the title
alimanfoo
commented
Aug 30, 2024
.github/workflows/tests.yml
Outdated
Comment on lines
28
to
29
| - name: Install package | ||
| run: pip install "numpy${{ matrix.numpy-version }}" .[dev] |
There was a problem hiding this comment.
Revert to using pip to install the package, because poetry does not give us the flexibility to run tests against different versions of numpy as far as I can make out.
alimanfoo
commented
Aug 30, 2024
Comment on lines
+88
to
+90
| [tool.poetry.extras] | ||
| dev = ["pytest", "pytest-xdist", "pytest-cases", "pytest-cov", "notebook", "jupyterlab", "pre-commit", "ruff", "snakeviz", "mypy", "memory-profiler", "sphinx", "pydata-sphinx-theme", "sphinx_design"] | ||
|
|
There was a problem hiding this comment.
Changing this to use the "extras" feature, so can be installed via pip install malariagen_data[dev].
ahernank
approved these changes
Sep 1, 2024
alimanfoo
commented
Sep 2, 2024
| @@ -7,7 +7,7 @@ on: | |||
| branches: | |||
| - master | |||
| jobs: | |||
| tests: | |||
| legacy_tests: | |||
There was a problem hiding this comment.
Clarify naming to make actions easier to find when setting branch protections.
alimanfoo
added
the
BMGF-068808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub action which runs the unit tests has been modified to run tests under both numpy 1.x and numpy 2.x.