Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools to requirements.txt #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cristeigabriel
Copy link

Running setup.py install requires the presence of the setuptools pip package. Along with a fresh Python install, adding this entry to requirements.txt makes following the installation documentation work without trouble.

As an addendum, I would recommend checking if the Python version is in WindowsApps in the setup.py file, in which case to bail early. I've found that SetupTools wants to do modifications in the Python path, which it wouldn't have permission to the way the application is packaged. If welcomed, I would be willing to also implement this to make our PR more substantial.

Copy link

google-cla bot commented Jan 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant